Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script to restrict hedxml/hedwiki/hedtsv when not on admin branch #258

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update script to restrict hedxml/hedwiki/hedtsv when not on admin branch #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions scripts/verify_branch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,19 @@ else
base_pattern="library_schemas/${branch_prefix}/"
fi

# Define the second pattern by appending 'prerelease' to the base pattern
# Valid location for schemas
file_pattern="${base_pattern}prerelease/"

# Check if the file paths start with the defined pattern for specified extensions
# Banned locations for ANY changes
declare -a banned_patterns=(
"${base_pattern}hedxml/"
"${base_pattern}hedwiki/"
"${base_pattern}hedtsv/"
)

for file in "$@"; do # "$@" will contain the list of modified files passed by pre-commit
extension="${file##*.}"
# Check files based on their extension
# First check schemas in the correct location, and validate them.
if [[ "$extension" == "xml" || "$extension" == "mediawiki" || "$extension" == "tsv" ]]; then
if [[ "$file" != "$file_pattern"* ]]; then
error_message+="Error: '$file' with extension .$extension should start with '$file_pattern'\n"
Expand All @@ -58,11 +64,21 @@ for file in "$@"; do # "$@" will contain the list of modified files passed by p
fi
fi
else
# Allow other files to be modified anywhere under the base pattern directory
if [[ "$file" != "$base_pattern"* ]]; then
error_message+="Error: '$file' should not be modified on this branch. Only files under '$base_pattern' directory should be modified.\n"
fi
is_banned=false

# Check against each banned pattern
for banned_pattern in "${banned_patterns[@]}"; do
if [[ "$file" == "$banned_pattern"* ]]; then
error_message+="Error: '$file' is in a restricted directory '$banned_pattern'. Modifications are not allowed in this directory.\n"
is_banned=true
break
fi
done

# Check if the file is not under the base pattern and not already banned
if [[ "$file" != "$base_pattern"* && "$is_banned" == false ]]; then
error_message+="Error: '$file' should not be modified on this branch. Only files under '$base_pattern' directory should be modified.\n"
fi
fi
done

Expand Down