-
Notifications
You must be signed in to change notification settings - Fork 292
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] Fix ask modal not being shown after editing program (#4459)
**Description** I replaced all of the references to the variable `askPromptShown` to reference the variable in the editor object. This caused that when you didn't answer an ask the variable wasn't being set correctly. I also added a couple of test for the ask modal. **Fixes #4458 ** **How to test** The cypress should suffice, but you can also try it going to level 1 and typing the program: ``` print Hello ask hello ``` then execute that program and write in the editor box without answering the input: print hello Now when you run the program again the input should be shown normally. **Checklist** Done? Check if you have it all in place using this list: (mark with x if done) - [ ] Contains one of the PR categories in the name - [ ] Describes changes in the format above - [ ] Links to an existing issue or discussion - [ ] Has a "How to test" section If you're unsure about any of these, don't hesitate to ask. We're here to help!
- Loading branch information
Showing
4 changed files
with
69 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters