Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answers for level 1 in the teacher manual #4314

Closed
wants to merge 4 commits into from

Conversation

MarleenGilsing
Copy link
Collaborator

Hi @Felienne,

I made this using the structure of the common mistakes part of the teacher manual. If you like it this way, I can make it for all the other levels as well.

@ghost
Copy link

ghost commented May 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member

Thanks @MarleenGilsing!

Contrary to the other parts of content, here you will have to manually copy the new content from English to the other languages or Weblate will get angry and delete stuff (this is why the tests are failing).

@Felienne
Copy link
Member

Otherwise, this is a great change!!

I was also thinking, can we make a new user account (Hedy_answers or something), save all the answers there and link to them? That will make it easier for people to find them.

@MarleenGilsing
Copy link
Collaborator Author

We could merge this to the website. It's the answers upto level 3 now. But as we discussed, I think linking to the answer accounts might be a better idea, because this was quite a hassle.

@MarleenGilsing
Copy link
Collaborator Author

@Felienne I have made #4372 now and I think it might be a better way of showing the answers than this idea. It might have been a bit of waste of my time to make this PR then, but I think it will look weird to have the answers of level 1-3 looking like this and then referring to the user account for all the other answrs.

I will manually copy the new content of that answer-account PR to the other languages, because the tests are failing there too.

@MarleenGilsing
Copy link
Collaborator Author

We decided to use the answer account instead of this way, so I'm closing this PR. It should not be merged.

@Felienne Felienne deleted the Teacher-manual-answers branch November 23, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants