Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini adjustments to start codes in dutch for slides #4342

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

MarleenGilsing
Copy link
Collaborator

First a pull request without making weblate or the tests mad (hopefully).

@ghost
Copy link

ghost commented Jun 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MarleenGilsing
Copy link
Collaborator Author

I did it like this on a seperate branch, with 2 the last 2 commits that might make weblate and the tests mad if you merge them before merging the other PR. But if we merge the PR #4332 first (adds the adventures in english), then I think weblate shouldn't mind this one (adding the same adventures in dutch).

And yes, this is still my omweg, but i already made it haha. Just couldn't upload it yet because internet and travelling.

@Felienne
Copy link
Member

I did it like this on a seperate branch, with 2 the last 2 commits that might make weblate and the tests mad if you merge them before merging the other PR. But if we merge the PR #4332 first (adds the adventures in english), then I think weblate shouldn't mind this one (adding the same adventures in dutch).

And yes, this is still my omweg, but i already made it haha. Just couldn't upload it yet because internet and travelling.

No problemo! We will deal with the omweg :) Is #4332 ready to go or does that still need work?

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0772df4 into main Jun 22, 2023
@mergify mergify bot deleted the Mini-adjustments-to-start-codes-in-dutch-for-slides branch June 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants