Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] Teacher manual improvements NL EN #4425

Merged
merged 18 commits into from
Sep 25, 2023
Merged

Conversation

MarleenGilsing
Copy link
Collaborator

The teacher manual is fully up to date again! :)

I would only like to add the answer account to it, but #4424

Some tests might get angry because I've added some headers that will not exist yet in other languages.
Weblock will definitely be angry, haha.

@MarleenGilsing MarleenGilsing added Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times teachers Issues related to the teacher's UI labels Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MarleenGilsing MarleenGilsing marked this pull request as draft September 7, 2023 11:54
@MarleenGilsing
Copy link
Collaborator Author

@Felienne This one is done. I changed it for all languages, but the vi and bg languages seem to have a different structure. I couldn't figure out how to change everything in those 2 languages.

@Felienne Felienne changed the title Teacher manual improvements NL EN [CONTENT] Teacher manual improvements NL EN Sep 7, 2023
@Felienne Felienne marked this pull request as ready for review September 25, 2023 14:19
@Felienne
Copy link
Member

ok, I hope Turkish is ok! If so, we can merge this now!

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5cc60d2 into main Sep 25, 2023
9 checks passed
@mergify mergify bot deleted the Teacher-manual-improvements branch September 25, 2023 15:15
@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@yilmazdurmaz
Copy link
Contributor

It is hard for me to follow all these changes, especially when you move parts up and down in yaml files. are you making these changes manually or through a program?
thus, I am counting on them appearing on Weblate as "needs editing".

by the way, I noticed there were a lot of content changes on the source but these did not change on other languages that got their strings from auto-translation (actually auto-copy from source). Some quiz questions were completely different than the source. do you have an easy way to detect them and sync to latest?

@Felienne
Copy link
Member

It is hard for me to follow all these changes, especially when you move parts up and down in yaml files. are you making these changes manually or through a program? thus, I am counting on them appearing on Weblate as "needs editing".

Yes, Weblate should see then as "needs editing". Let me know if anything is amiss.

by the way, I noticed there were a lot of content changes on the source but these did not change on other languages that got their strings from auto-translation (actually auto-copy from source). Some quiz questions were completely different than the source. do you have an easy way to detect them and sync to latest?

Yes this is a known issue in Weblate sadly, but there is no easy way to fix this, other than a manual find and replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teachers Issues related to the teacher's UI Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants