Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] Adds test for Hedy's choice programs #4460

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Sep 6, 2023

Description

The Hedy's choice programs were not functioning for a while, so this tests makes sure that if they fail, it won't go unnoticed again.

Fixes #4407

Checklist
Done? Check if you have it all in place using this list: (mark with x if done)

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@jpelay
Copy link
Member Author

jpelay commented Sep 6, 2023

For some reason is saying this when you execute the test for the first time. I'll look into it tomorrow:
image

@jpelay
Copy link
Member Author

jpelay commented Sep 7, 2023

For some reason is saying this when you execute the test for the first time. I'll look into it tomorrow: image

Managed to reproduce the issue locally! 🥳
image

@jpelay
Copy link
Member Author

jpelay commented Sep 7, 2023

The error was a wrong reference to jQuery, I changed the reference to a JavaScript native function and it's fixed now.

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dbfd28d into hedyorg:main Sep 9, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Add front-end test for Hedy's choice programs
2 participants