-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Highlighted commands are shown in errors again #4468
Conversation
Haha I just noticed this while working on something and I thought I had broken it :) Thanks for the fix! |
hahaha No worries, I'm trying to get the tests to work and then it'll be ready! |
The test were failing in the command line because of timing. I looked up for a while, but couldn't get it to work without the wait. I left a TODO comment to tackle this in the future. |
Let's see if a higher time works! |
Yes let's see! Hopefully it will! For me it also worked without waits in the command line using the option |
I don't know either, so I am not sure how we can move this forward at the moment |
According to Cypress, yes we can, but since I'm working in the debugger at the moment, I'll tackle this on Monday! Do I set this as a draft in the meantime? |
The test that was failing was a flaky cypress test that I already opened an issue for in #4455. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sigh, these test failed in https://github.com/hedyorg/hedy/actions/runs/6158212111 :c in #4471 |
Let's not worry about it all too much, we can discuss tonight! |
Description
There's a bug right now in Hedy were the keywords in the errors are not being highlighted:
This is due to a syntax error in
additional.css
. Now is back to normal: