Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] removes logs and old stats page (in HTML) #4474

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Sep 13, 2023

We just merged the new stats page (#4166) so let's remove the old one, and the stats. This PR just removes it from the front-end to not overload teachers, but we'd also like to remove the Python and js code, see: #4475.

@ghost
Copy link

ghost commented Sep 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne changed the title [UI] remove logs and old stats page (in HTML) [UI] removes logs and old stats page (in HTML) Sep 13, 2023
@Felienne Felienne merged commit 5fb9baf into main Sep 13, 2023
7 checks passed
@Felienne Felienne deleted the remove-old-stats-and-logs branch September 13, 2023 13:14
jtwaleson added a commit to jtwaleson/hedy that referenced this pull request Sep 16, 2023
This was probably an oversight in hedyorg#4474

As we are going to remove all references to the old /stats/ and /logs/
pages this needs to be removed too.
jtwaleson added a commit to jtwaleson/hedy that referenced this pull request Sep 16, 2023
This was probably an oversight in hedyorg#4474

As we are going to remove all references to the old /stats/ and /logs/
pages this needs to be removed too.
jtwaleson added a commit to jtwaleson/hedy that referenced this pull request Sep 22, 2023
This was probably an oversight in hedyorg#4474

As we are going to remove all references to the old /stats/ and /logs/
pages this needs to be removed too.
jtwaleson added a commit to jtwaleson/hedy that referenced this pull request Sep 22, 2023
This was probably an oversight in hedyorg#4474

As we are going to remove all references to the old /stats/ and /logs/
pages this needs to be removed too.
jtwaleson added a commit to jtwaleson/hedy that referenced this pull request Sep 22, 2023
This was probably an oversight in hedyorg#4474

As we are going to remove all references to the old /stats/ and /logs/
pages this needs to be removed too.
mergify bot pushed a commit that referenced this pull request Sep 22, 2023
**Description**

Removes outdated resources (html, routes and typescript) after #4474 was merged.

Fixes #4475

**How to test**

- CI should cover most
- Check if stats pages for teachers and admins work

**Checklist**
Done? Check if you have it all in place using this list: (mark with x if done)

- [x] Contains one of the PR categories in the name
- [x] Describes changes in the format above
- [x] Links to an existing issue or discussion
- [x] Has a "How to test" section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant