-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] removes logs and old stats page (in HTML) #4474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/hedy into remove-old-stats-and-logs
Felienne
changed the title
[UI] remove logs and old stats page (in HTML)
[UI] removes logs and old stats page (in HTML)
Sep 13, 2023
jtwaleson
added a commit
to jtwaleson/hedy
that referenced
this pull request
Sep 16, 2023
This was probably an oversight in hedyorg#4474 As we are going to remove all references to the old /stats/ and /logs/ pages this needs to be removed too.
jtwaleson
added a commit
to jtwaleson/hedy
that referenced
this pull request
Sep 16, 2023
This was probably an oversight in hedyorg#4474 As we are going to remove all references to the old /stats/ and /logs/ pages this needs to be removed too.
4 tasks
jtwaleson
added a commit
to jtwaleson/hedy
that referenced
this pull request
Sep 22, 2023
This was probably an oversight in hedyorg#4474 As we are going to remove all references to the old /stats/ and /logs/ pages this needs to be removed too.
jtwaleson
added a commit
to jtwaleson/hedy
that referenced
this pull request
Sep 22, 2023
This was probably an oversight in hedyorg#4474 As we are going to remove all references to the old /stats/ and /logs/ pages this needs to be removed too.
jtwaleson
added a commit
to jtwaleson/hedy
that referenced
this pull request
Sep 22, 2023
This was probably an oversight in hedyorg#4474 As we are going to remove all references to the old /stats/ and /logs/ pages this needs to be removed too.
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
**Description** Removes outdated resources (html, routes and typescript) after #4474 was merged. Fixes #4475 **How to test** - CI should cover most - Check if stats pages for teachers and admins work **Checklist** Done? Check if you have it all in place using this list: (mark with x if done) - [x] Contains one of the PR categories in the name - [x] Describes changes in the format above - [x] Links to an existing issue or discussion - [x] Has a "How to test" section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just merged the new stats page (#4166) so let's remove the old one, and the stats. This PR just removes it from the front-end to not overload teachers, but we'd also like to remove the Python and js code, see: #4475.