Functions adventures

[MarleenGilsing]

Creating function adventures. But I'm not done yet.

@Felienne would you mind taking a look, before I continue next week?

[ghost]

👇 Click on the image for a new way to code review

Legend

[MarleenGilsing]

I still have to make sure that each adventure has an exercise, that there are {} around the keywords and check if I have used = ask instead of {is} {ask}.

I have made slides (English) for level 12 and 13. Not 14 yet and I haven't put them in the other languages yet.

@Felienne Could you check out the weird test failure?

[MarleenGilsing]

@Felienne I feel like this is ready to go, but I have some errors from the tests. Could you take a look?

[Felienne]

I have managed to fix all merge conflicts, only French was too much changed to be salvaged, so French now lacks the new function texts (cc @etienneCharignon, who might want to pick that up when we have merged this? 🙏 )

[etienneCharignon]

If I understand well, this has an impact from level 12 and next. I'm translating level by level and reached the level 6 for now. Will this be waiting for me to reach the level 12 (it might be in 5 weeks), or should I look at something before?

[Felienne]

Ok @MarleenGilsing this took about 2 hours to debug haha, but I think I found the issue... in hedy_content.py, you added functions_2 and functions_3 but they don't exist, leading to errors.

[Felienne]

If I understand well, this has an impact from level 12 and next. I'm translating level by level and reached the level 6 for now. Will this be waiting for me to reach the level 12 (it might be in 5 weeks), or should I look at something before?

Indeed, this will only be an issue in level 12 and up, once you are there, you should see text in English about functions that does not yet exist in the English text in the *.fr files (but if you use Weblate, it should be clear, if not, let us know!)

[MarleenGilsing]

@Felienne Oh my gosh I'm sorry! I did create functions_2 and 3, but then i placed the content in the already existing adventures like songs and calculator. Guess I forgot to remove them from hedy_content.py.... Thanks for debugging it though!!

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).