Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] Weblate fix script #4544

Merged
merged 19 commits into from
Sep 27, 2023
Merged

[TESTING] Weblate fix script #4544

merged 19 commits into from
Sep 27, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Sep 24, 2023

One of our biggest time sinks is fixing Weblate snippets (it is mine for sure and I could use my time in better ways). Sometimes, this is needed because a weblate PR is blocking other content PRs. While of course it is not great to throw away snippets, and we should fix them when possible, this PR introduces an environment variable called fix_for_weblate, which can be set to revert broken snippets back to English. So if needed this can be used

@ghost
Copy link

ghost commented Sep 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne marked this pull request as ready for review September 27, 2023 08:11
@Felienne Felienne added the Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times label Sep 27, 2023
@jpelay jpelay self-assigned this Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3feaa9f into main Sep 27, 2023
9 checks passed
@mergify mergify bot deleted the weblate-fix-script branch September 27, 2023 18:29
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants