Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] Redoing Marleen's changes from 4332 #4553

Merged
merged 7 commits into from
Sep 29, 2023
Merged

[CONTENT] Redoing Marleen's changes from 4332 #4553

merged 7 commits into from
Sep 29, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Sep 26, 2023

@MarleenGilsing, I am not sure your notes are still relevant but here they are:

Note to self that I still have to make these changes in Dutch:

In het NL nog aanpassen:

Level 4: default voorbeeldcode is startcode
quotation marks intro voorbeeldcode = startcode en toevoeging ‘from now on’

Level 6 : maths voorbeeldcode = startcode
Is_command toevoegen met startcode die nu vbc is.
Calculator adventure voorbeeldcode is startcode

Level 9: if los avontuur maken met een if in een if.

Level 10: dishes vbc wordt startcode
Level 11 calculator vbc wordt startcode

Level 14 default:
answer = ask 'Do you want to learn more?'
if answer == 'yes'
print 'Go to the next adventure!'
if answer != 'yes'
print 'That is a shame!'

Level 16 random vbc to startcode

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Note to self that I still have to make these changes in Dutch:

In het NL nog aanpassen:

Level 4: default voorbeeldcode is startcode
 quotation marks intro voorbeeldcode =  startcode en toevoeging ‘from now on’

Level 6 : maths voorbeeldcode = startcode
Is_command toevoegen met startcode die nu vbc is.
Calculator adventure voorbeeldcode is startcode

Level 9: if los avontuur maken met een if in een if.

Level 10: dishes vbc wordt startcode
Level 11 calculator vbc wordt startcode

Level 14 default:
answer = ask 'Do you want to learn more?'
if answer == 'yes'
    print 'Go to the next adventure!'
if answer != 'yes'
    print 'That is a shame!'

Level 16 random vbc to startcode
@ghost
Copy link

ghost commented Sep 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member Author

Hi @MarleenGilsing!

I have moved all changes from #4332 to here, except the one where you copy the changes from En to all languages (f579d35) That one caused too many conflicts. Can you do that one again with ctrl-f?

@Felienne Felienne added the Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times label Sep 26, 2023
@Felienne Felienne marked this pull request as ready for review September 28, 2023 19:35
@Felienne Felienne merged commit 77a2b4c into main Sep 29, 2023
@Felienne Felienne deleted the redo-4332 branch September 29, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants