Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Profile live statistics page #5365

Merged
merged 2 commits into from
Apr 4, 2024
Merged

🧪 Profile live statistics page #5365

merged 2 commits into from
Apr 4, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Apr 4, 2024

Adds a sort of profiling to this page by placing some timers in some key function where I think the slowdown happens. Why is it so hacky? I tried for several hours to use werkzeug's ProfilerMiddleware but I think there's a bug with the implementation, as several people have reported in some other tools: django-commons/django-debug-toolbar#1875, jazzband/django-silk#682

I thought that since we didn't need the full-fledged tool and didn't want to spend more time on this, this approach would suffice.

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving in!! Do we want to make a note somewhere (an issue?) so that we don't forget to remove this code when we are done?

Copy link
Contributor

mergify bot commented Apr 4, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f3ec87 into main Apr 4, 2024
12 checks passed
@mergify mergify bot deleted the profile-statistics branch April 4, 2024 05:30
@jpelay
Copy link
Member Author

jpelay commented Apr 5, 2024

Thanks for diving in!! Do we want to make a note somewhere (an issue?) so that we don't forget to remove this code when we are done?

I will remove them when I address the slowness so Ill be touching this code very soon!

@Felienne
Copy link
Member

Felienne commented Apr 5, 2024

Thanks for diving in!! Do we want to make a note somewhere (an issue?) so that we don't forget to remove this code when we are done?

I will remove them when I address the slowness so Ill be touching this code very soon!

Yes, the profiling is deployed now so you can dive in when you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants