Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Refactor cypress tests (part 3) #5592

Merged
merged 51 commits into from
Jun 18, 2024
Merged

🧪 Refactor cypress tests (part 3) #5592

merged 51 commits into from
Jun 18, 2024

Conversation

Annelein
Copy link
Contributor

@Annelein Annelein commented Jun 4, 2024

Refactors the entire for-teacher folder for #4027 :

  • customize-adventure folder only data-cy and .it() refactoring

How to test
I think the best way is to click around the for-teacher page tests and see if they are structured better, readabilty improved and if they cover testing the whole for-teacher page

@Annelein Annelein mentioned this pull request Jun 4, 2024
19 tasks
@Annelein
Copy link
Contributor Author

Annelein commented Jun 5, 2024

@Felienne this was meant as a draft!

@Felienne Felienne marked this pull request as draft June 5, 2024 08:58
@Annelein Annelein marked this pull request as ready for review June 13, 2024 13:11
@Annelein Annelein requested a review from jpelay June 13, 2024 13:11
@Annelein Annelein assigned Annelein and unassigned Annelein Jun 13, 2024
@Annelein
Copy link
Contributor Author

@jpelay added the tests for second teachers! so its ready

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine! Great job by grouping some of these tests and simplifying them

@@ -1,195 +0,0 @@
import { loginForTeacher } from '../../tools/login/login.js'

describe('customize class page', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call grouping these in customize_class!

@@ -2,21 +2,20 @@ import {loginForTeacher} from '../../tools/login/login.js'
import {goToEditAdventure} from '../../tools/navigation/nav.js'
import { createAdventure } from '../../tools/adventures/adventure.js'

describe('Preview button test', () => {
it('passes', () => {
it('Preview button test', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should say "Remove button test"

Copy link
Contributor

mergify bot commented Jun 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jun 18, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9cd260b into main Jun 18, 2024
12 checks passed
@mergify mergify bot deleted the ref-cyp-tests branch June 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants