-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Refactor cypress tests (part 3) #5592
Conversation
@Felienne this was meant as a draft! |
tests/cypress/e2e/for-teacher_page/class_page/other_buttons.cy.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/for-teacher_page/customize_class_page/preview_class.cy.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/for-teacher_page/customize_class_page/quiz_parsons.cy.js
Outdated
Show resolved
Hide resolved
@jpelay added the tests for second teachers! so its ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working fine! Great job by grouping some of these tests and simplifying them
@@ -1,195 +0,0 @@ | |||
import { loginForTeacher } from '../../tools/login/login.js' | |||
|
|||
describe('customize class page', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call grouping these in customize_class
!
@@ -2,21 +2,20 @@ import {loginForTeacher} from '../../tools/login/login.js' | |||
import {goToEditAdventure} from '../../tools/navigation/nav.js' | |||
import { createAdventure } from '../../tools/adventures/adventure.js' | |||
|
|||
describe('Preview button test', () => { | |||
it('passes', () => { | |||
it('Preview button test', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should say "Remove button test"
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Refactors the entire
for-teacher folder
for #4027 :customize-adventure folder
only data-cy and .it() refactoringHow to test
I think the best way is to click around the for-teacher page tests and see if they are structured better, readabilty improved and if they cover testing the whole for-teacher page