Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Correct the message for keypresses #6005

Merged
merged 2 commits into from
Dec 2, 2024
Merged

📜 Correct the message for keypresses #6005

merged 2 commits into from
Dec 2, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

This PR changes the message displayed to the user Waiting for a button press to Waiting for a keypress. This is needed because we do not have buttons and all content refers to keys, not buttons. Also note that keypress is one word.

Fixes #3856

How to test
Go to level 5 and write any if-pressed program (e.g. if x is pressed print 'x' else print 'other') and run it. Check that the message in the output screen is updated.

@boryanagoncharenko boryanagoncharenko changed the title 📜 Correct the message for keypress es 📜 Correct the message for keypresses Dec 2, 2024
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!
image

Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 71c8290 into main Dec 2, 2024
11 checks passed
@mergify mergify bot deleted the rename_3856 branch December 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Change "Waiting for a button press..." into "Waiting for a key press..." when appropriate
2 participants