Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: MP Reactive Messaging POC #1148

Closed
wants to merge 66 commits into from
Closed

WIP: MP Reactive Messaging POC #1148

wants to merge 66 commits into from

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Nov 17, 2019 •
edited
Loading

@romain-grecourt
Copy link
Contributor

romain-grecourt commented Nov 18, 2019 •
edited
Loading

Quick comments:

  • Make sure you add/update the unit tests for common/reactive so that the code coverage remain high (mvn test -Pcoverage)
  • Some classes can be kept package protected: LimitProcessor, PeekProcessor, FilterProcessor, MultiMappingProcessor, BaseProcessor. Though BaseProcessor can be potentially useful to end-users, one could argue it should actually be public.

@danielkec danielkec force-pushed the kafka-mp-messaging-connector branch 3 times, most recently from 4f15c2d to 0e1dd0c Compare November 23, 2019 10:03
@m0mus m0mus mentioned this pull request Dec 12, 2019
Closed
39 tasks
@danielkec danielkec force-pushed the kafka-mp-messaging-connector branch from 5f184f8 to 7423da5 Compare December 14, 2019 01:50
@romain-grecourt
Copy link
Contributor

Some of your updates to common/reactive are great. Could you submit them with a separate PR so that we can review the changes apart from the microprofile implementation ?

@danielkec
Kafka connector with partial MicroProfile Reactive Messaging Specific…
6d3ea5e 
…ation

Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Proper context propagation
783b2bc 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
First few passable tck tests
88b37e9 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Extra ugly ReactiveStreamEngine POC with Multi support
dad9924 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Trivial Helidon engine implementation with fist few tck tests passing
4a1dac4 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
More tck bending
e8d86e4 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Internal processor impl
63a337e 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 8/14 tck tests
92ae9b8 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 10/14 tck tests
175c2e7 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Major refactor
5b9c714 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Reactive engine - support from more stages (peek, filter)
651c735 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 11/14 tck tests
c93ae8e 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Reactive streams Multi integration
aeb3613 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 12/14 tck tests
71b7007 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing processor shape tests with Multi, not with small-rye
07e6bd4 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing all MicroProfile Reactive Messaging tck tests
df643ea 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Naming convention cleanup
64a7577 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Check-style and coverage for:
b3b5ba8 
  * Helidon Microprofile Reactive Streams Operators
  * Helidon Common Reactive

Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Check-style fixes for MP Reactive Messaging
e7b7015 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Spot-bugs fixes
11d6ecf 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Method signatures decomposition to different ack types
3ccfea0 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1044 failing 173/1948 MP RS operators tck tests
a69e63e 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1106 failing 131/1948 MP RS operators tck tests
1f85366 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1136 failing 104/1948 MP RS operators tck tests
6888226 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1160 failing 81/1948 MP RS operators tck tests
0ea5559 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1187 failing 54/1948 MP RS operators tck tests
c6b8287 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1190 failing 50/1948 MP RS operators tck tests
b04903f 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1202 failing 44/1948 MP RS operators tck tests
ec0d4f2 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1208 failing 36/1948 MP RS operators tck tests
124869c 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
After rebase fix
934a93a 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1216 failing 29/1948 MP RS operators tck tests
b49eb2e 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1221 failing 24/1948 MP RS operators tck tests
56254f1 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1226 failing 19/1948 MP RS operators tck tests
7a5669c 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Passing 1246 failing 2/1948 MP RS operators tck tests
4d323e1 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Clean up, Coupled deadlock fix, FlatMap lost last item fix
ff02bf3 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Move additional processors to common module
f309ed8 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Move tapped processor to common module
2a4270a 
  * Sequential lock for onSubscribe call

Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Move RS augments to BaseProcessor
5ed330d 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Checkstyle cleanup of common module
31e045d 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Reabase on java.util.concurrent.Flow
da8b165 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec force-pushed the kafka-mp-messaging-connector branch from 7d75478 to da8b165 Compare December 27, 2019 20:03
@danielkec
Copy link
Contributor Author

Some of your updates to common/reactive are great. Could you submit them with a separate PR so that we can review the changes apart from the microprofile implementation ?

Sure /pull/1260

@danielkec
Checkstyle fixes
ff2812c 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
FlatMap buffer overflow fix,
6699433 
  * breaks FlatMapStageVerification$InnerSubscriberVerification.required_spec209_mustBePreparedToReceiveAnOnCompleteSignalWithoutPrecedingRequestCall

Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Multi PR review issues fix
8c873fa 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Multi PR review issues fix
e17290c 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Multi PR review issues fix
7d25ccf 
  * Unusual method name fix
  * Copyright year

Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Remove Valve helidon-io/issues/514
17f8342 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
HttpRequestScopedPublisher doesn't close connection
e31d54b 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Copyright fix for happy new year 2020!
82e4926 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt left review comments

Assignees

@danielkec danielkec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielkec @romain-grecourt