Windows Github Action #7227
Open
Windows Github Action #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
reviewed
Sep 25, 2023
inject/processor/src/main/java/io/helidon/inject/processor/ActiveProcessorUtils.java
Outdated
Show resolved
Hide resolved
.../test/java/io/helidon/integrations/oci/sdk/runtime/OciAuthenticationDetailsProviderTest.java
Outdated
Show resolved
Hide resolved
...o/helidon/nima/tests/integration/http2/webserver/Http2ErrorHandlingWithOutputStreamTest.java
Outdated
Show resolved
Hide resolved
...ebclient/webclient/src/test/java/io/helidon/nima/tests/integration/client/HttpProxyTest.java
Outdated
Show resolved
Hide resolved
tvallin
force-pushed
the
windows-build
branch
from
c4c4558 to
50d7204
Compare
edbratt
reviewed
Dec 7, 2023
builder/tests/builder/src/test/java/io/helidon/builder/test/CustomNamedTest.java
Show resolved
Hide resolved
edbratt
reviewed
Dec 7, 2023
inject/processor/src/main/java/io/helidon/inject/processor/ActiveProcessorUtils.java
Outdated
Show resolved
Hide resolved
edbratt
reviewed
Dec 7, 2023
There was a problem hiding this comment.
In general, I can confirm these updates work for my Windows build system. I would recommend addressing the file-system separator, end-of-line and other issues (if they exist) using the system properties and appropriate settings. (e.d. system properties: line.separator, File.separator, and File.pathSeparator)
tvallin
force-pushed
the
windows-build
branch
from
50d7204 to
3dcc933
Compare
tvallin
force-pushed
the
windows-build
branch
2 times, most recently
from
fc5656f to
b958fd2
Compare
tvallin
force-pushed
the
windows-build
branch
from
6f89e58 to
1cc5b8f
Compare
tvallin
force-pushed
the
windows-build
branch
from
2fe8321 to
f13a55b
Compare
tvallin
force-pushed
the
windows-build
branch
from
f13a55b to
89f4138
Compare
|
This is ready for review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6717
Fixes #6714
Documentation
Run unit tests and packaging (jar, jlink and native-image) on windows.
Performance before changes (main): 24m 38s
Performance after changes: 27m 16s