Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix Micronaut integration in Helidon 3.x? #7206 #8227

Open
wants to merge 5 commits into
base: helidon-3.x
Choose a base branch
from

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jan 12, 2024

Description

Using Micronaut 4.x in Helidon 3.x: #7206

Documentation

N/A

A couple of comments:

  1. I had to remove helidon/integrations/micronaut/cdi-processor/src/main/java/module-info.java because there was one issue with Micronaut modules having same packages. I opened an issue: the unnamed module reads package io.micronaut.inject.annotation from both io.micronaut.core_processor and io.micronaut.inject micronaut-projects/micronaut-core#10299 . Anyway, as we use this module for annotation processing there is no real need to have a module-info.
  2. helidon/integrations/micronaut/cdi/src/test/java/io/helidon/integrations/micronaut/cdi/TestBothBean.java is implementing one intrface with default methods and inherited annotations. I had to override the methods and add again the annotations. It seems a bug in Micronaut.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 12, 2024
@jbescos jbescos force-pushed the issue7206 branch 3 times, most recently from de5dd10 to ca4bc7a Compare January 12, 2024 14:06
@jbescos
Copy link
Member Author

jbescos commented Jan 15, 2024

There is one issue with validation:
micronaut-projects/micronaut-core#10370

Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Copy link
Member Author

jbescos commented Mar 21, 2024

Now Helidon examples exists in [email protected]:helidon-io/helidon-examples.git, and this makes a problem.

If you make a change in Helidon that requires modifications in examples, you are in a dead lock. You cannot submit in Helidon because examples fails, and you cannot submit in examples because the Helidon changes are not in place.

@jbescos
Copy link
Member Author

jbescos commented Mar 21, 2024

Examples fails because it also require changes:
helidon-io/helidon-examples#32

@jbescos jbescos requested a review from romain-grecourt April 2, 2024 08:57
@barchetta
Copy link
Member

barchetta commented Apr 26, 2024

As you see the examples checks are not required. Therefore, no deadlock. When you are in this situation the procedure is:

  1. Proceed with this PR. You will not be blocked by the examples check. You should comment as to why the examples fail to build (so we understand if you are introducing an incompatibility).
  2. Create a PR against https://github.com/helidon-io/helidon-examples/tree/dev-3.x to adjust the example (and you already have). It will fail build check until the first PR is merged.
  3. Once the first PR is approved you can merge it. You will not be blocked by the examples check.
  4. Then the second PR will then pass the build check and you can have it reviewed and merge it.

Yes, this is inconvenient, but it's the cost of moving the examples out of the primary repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants