-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Fix Micronaut integration in Helidon 3.x? #7206 #8227
base: helidon-3.x
Are you sure you want to change the base?
Conversation
de5dd10
to
ca4bc7a
Compare
There is one issue with validation: |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Now Helidon examples exists in [email protected]:helidon-io/helidon-examples.git, and this makes a problem. If you make a change in Helidon that requires modifications in examples, you are in a dead lock. You cannot submit in Helidon because examples fails, and you cannot submit in examples because the Helidon changes are not in place. |
Examples fails because it also require changes: |
As you see the examples checks are not required. Therefore, no deadlock. When you are in this situation the procedure is:
Yes, this is inconvenient, but it's the cost of moving the examples out of the primary repository. |
Description
Using Micronaut 4.x in Helidon 3.x: #7206
Documentation
N/A
A couple of comments:
helidon/integrations/micronaut/cdi-processor/src/main/java/module-info.java
because there was one issue with Micronaut modules having same packages. I opened an issue: the unnamed module reads package io.micronaut.inject.annotation from both io.micronaut.core_processor and io.micronaut.inject micronaut-projects/micronaut-core#10299 . Anyway, as we use this module for annotation processing there is no real need to have a module-info.