Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Upgrade checkout to v4, setup-java to v4.1.0 #8447

Merged

Conversation

barchetta
Copy link
Member

Description

Upgrades GitHub actions:

  • setup-java to v4.1.0
  • checkout to v4

See #8435

Documentation

No impact

@barchetta barchetta added the build label Mar 2, 2024
@barchetta barchetta self-assigned this Mar 2, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 2, 2024
@senivam
Copy link
Member

senivam commented Mar 4, 2024

Looks like newer JDK (Temurin) fails the build:
Previous:

image

proposed in the PR:

image

@senivam
Copy link
Member

senivam commented Mar 4, 2024

For my local build of the PR everything works just fine:

Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /home/mavines/software/maven/apache-maven-3.9.5
Java version: 11.0.22, vendor: Oracle Corporation, runtime: /media/storage/software/java/jdk-11.0.22
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-21-generic", arch: "amd64", family: "unix"

@barchetta
Copy link
Member Author

The failing test is known to be unstable: #4323

@senivam
Copy link
Member

senivam commented Mar 4, 2024

The failing test is known to be unstable: #4323

why not to ignore it then? :D As I would say - no test no problem.

The strange thing about it is that it was failing 3 times in a row on the same JDK and all the time with different outputs.

@senivam
Copy link
Member

senivam commented Mar 4, 2024

To prove the issue is JDK related, I've done a tiny modification to your PR which is rolling back just one JDK version for the Helidon build:
image

Basically, the version of the action is not important, it does not relate to JDK's version, but they've just updated the Temurine JDK to 11.0.22. And I have to roll it back to the 11.0.21. After I did this the build just had passed OK:

image

Before the change it was failing in my local branch as well.

The reference to the passing action is https://github.com/senivam/helidon/actions/runs/8146385385
The reference to the code change is senivam@5ee64e9

@barchetta
Copy link
Member Author

The test is unstable due to a race condition so the changing of the JDK is likely altering timing. Looks like @danielkec fixed the race condition in 3.x but not 2.x. I've back ported the fix in #8453. Hopefully that resolves the problem!

@barchetta barchetta force-pushed the 2.x-github-action-to-v4 branch from 78f8743 to 1cd5199 Compare March 5, 2024 00:54
@barchetta barchetta merged commit 1502cee into helidon-io:helidon-2.x Mar 5, 2024
12 checks passed
@barchetta barchetta deleted the 2.x-github-action-to-v4 branch October 4, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants