Fix possible NPE if user code creates a REST client 'early' #9554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a few other things
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
approved these changes
Dec 4, 2024
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Dec 11, 2024
…a few other things (helidon-io#9554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user code creates a REST client before CDI announced that app-scoped beans have been initialized, then the Helidon REST client metrics CDI extension attempts to use its
MetricRegistryfield before it has been set. (That happens in a@Observes @Initialized(ApplicationScoped.class) eventobserver method.)This PR adds the ability to record such "early" REST clients (rather than acting on them immediately) if the metric registry field is null, and then once CDI provides the metric registry that observer method registers metrics for the so-called deferred REST clients.
This PR also cleans up some unrelated IDE-flagged items.
Documentation
No impact.