This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
add tag for the final batch of blocks in a sync #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deduplicate block send code update rebar.lock depends on helium/proto#125
Vagabond
reviewed
Mar 17, 2022
| @@ -139,8 +139,12 @@ handle_data(client, Data0, #state{blockchain=Chain, path=Path, gossiped_hash=Gos | |||
| %% nothing was plausible, see if it has anything else | |||
| {noreply, State, blockchain_sync_handler_pb:encode_msg(#blockchain_sync_req_pb{msg={response, true}})}; | |||
| HighestPlausible -> | |||
| lager:info("Eagerly re-gossiping ~p", [blockchain_block:height(HighestPlausible)]), | |||
| blockchain_gossip_handler:regossip_block(HighestPlausible, SwarmTID), | |||
| case Final of | |||
There was a problem hiding this comment.
So one thing we'd know now is that if we see the Final flag but we haven't seen the block with GossipedHash we know that this peer has more blocks (or that more blocks exist generally) and we can keep syncing immediately?
There was a problem hiding this comment.
Which I guess is something you'd call back into the blockchain_worker to before you {stop, normaled below
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deduplicate block send code
fixes #1273 depends on helium/proto#125