This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
sync_peer option to specify preferred nodes #1319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecaswell
force-pushed
the
jc/sync-peer-configuration-option
branch
from
cbad321
to
08574df
Compare
src/blockchain_worker.erl
Outdated
| State#state{sync_pid = Pid, sync_ref = Ref} | ||
| end. | ||
|
|
||
| get_configured_or_random_peer(SwarmTID) -> | ||
| case get_configured_sync_peer(SwarmTID) of | ||
| undefined-> get_random_peer(SwarmTID); |
There was a problem hiding this comment.
Suggested change
| undefined-> get_random_peer(SwarmTID); | |
| undefined -> get_random_peer(SwarmTID); |
Co-authored-by: Jeff Grunewald <[email protected]>
src/blockchain_worker.erl
Outdated
| [] -> | ||
| lager:debug("No sync_peers configured"), | ||
| undefined; | ||
| ConfiguredPeers -> |
There was a problem hiding this comment.
Suggested change
| ConfiguredPeers -> | |
| ConfiguredPeers when is_list(ConfiguredPeers) -> |
There was a problem hiding this comment.
As long as we're validating, we should check [P | _] when is_list(P) to make sure it is a list of strings, also should gracefully fail back to random so the node will still try to sync if the config is pooched.
src/blockchain_worker.erl
Outdated
Comment on lines
927
to
928
| {Left, Right} = lists:split(rand:uniform(length(ConfiguredPeers)), ConfiguredPeers), | ||
| get_configured_sync_peer(SwarmTID, Peerbook, Right ++ Left) |
There was a problem hiding this comment.
is this "cutting the deck" of configured peers so to speak? just a cheaper version of shuffling the list?
There was a problem hiding this comment.
Yes, exactly. We only need one peer, the rest of the list is only used if the chosen one fails to connect.
jeffgrunewald
approved these changes
Apr 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds blockchain sync_peers configuration option, accepts a list of string multi-addresses