This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
More verbose ledger_poc_v3:verify error #1343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihu
force-pushed
the
rg/poc-verification-specific-error
branch
from
0d43362
to
684c189
Compare
xandkar
suggested changes
May 18, 2022
| @@ -1202,8 +1202,8 @@ verify_poc_details(Txn, PoC, Keys) -> | |||
| SigFun = libp2p_crypto:mk_sig_fun(PrivKey), | |||
| SignedPayload = SigFun(OnionHash), | |||
| case blockchain_ledger_poc_v3:verify(PoC, Challenger, BlockHash) of | |||
| false -> {error, mismatched_poc}; | |||
| true -> | |||
| {error, R} -> {error, {mismatched_poc, R}}; | |||
There was a problem hiding this comment.
Need to update the spec of verify_poc_details/3 with this new error.
There was a problem hiding this comment.
Did it slightly differently though and made the error return a tuple of tuples.
There was a problem hiding this comment.
Sensible. So close to a record!
Co-authored-by: Siraaj Khandkar <[email protected]>
vihu
force-pushed
the
rg/poc-verification-specific-error
branch
from
9569a43
to
12860ea
Compare
xandkar
approved these changes
May 18, 2022
| @@ -1202,8 +1202,8 @@ verify_poc_details(Txn, PoC, Keys) -> | |||
| SigFun = libp2p_crypto:mk_sig_fun(PrivKey), | |||
| SignedPayload = SigFun(OnionHash), | |||
| case blockchain_ledger_poc_v3:verify(PoC, Challenger, BlockHash) of | |||
| false -> {error, mismatched_poc}; | |||
| true -> | |||
| {error, R} -> {error, {mismatched_poc, R}}; | |||
There was a problem hiding this comment.
Sensible. So close to a record!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When ledger POC verification fails we can't really tell whether it failed due to incorrect challenger or the block hash.
Solution
This switches the return type for
poc_v3:verifyto be anok | {error, ...}and passes it down.