Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

WIP to lookup challenge region once and thread the result through #1348

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vagabond
Copy link
Contributor

This is incomplete and it's not compatible with "old" receipts apis.

@PaulVMo
Copy link
Contributor

PaulVMo commented May 23, 2022

Additional thoughts on optimizing POC receipts. First, tagged_witnesses is checking both that the witness frequency is valid for the source region AND that the witness frequency matches the beacon frequency. The latter should be sufficient, especially since the regions are being checked to be the same already. At minimum, consider threading the SourceRegion frequencies through to the witness validation since it doesn't change.

Second, because the frequency check is happening and witnesses are capped to 100 km, there is not a lot of opportunity for witnessing across regions. thus, it might not even been necessary to check that the witness region is the same as the beaconer region. This would obviously be a larger change however but one that might be worth it to reduce the validation complexity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants