Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Fix miner#1779 by reverting PR 1412 #1450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpezely
Copy link
Contributor

@dpezely dpezely commented Aug 8, 2022

Fix helium/miner#1779 by reverting #1412
per conversation with @mikev

  • The lora library call reporting as undefined was invoked from the mentioned PR
  • Since that feature requires a future chain-var that has been put on hold, we can revert the feature by reversing its diff
  • Later, we can track why that lora library call is no longer available; e.g., API changed?
  • Preserved Pierre's additional fixes to pre-existing tests:
    • in test/blockchain_state_channel_SUITE.erl
wget https://github.com/helium/blockchain-core/pull/1412.diff
patch -p1 --reverse < 1412.diff

@dpezely dpezely requested review from evanmcc and mikev August 8, 2022 18:29
@Vagabond
Copy link
Contributor

Vagabond commented Aug 8, 2022

We added the dep to the app file so this maybe doesn't need to be reverted?

@dpezely
Copy link
Contributor Author

dpezely commented Aug 8, 2022

We added the dep to the app file so this maybe doesn't need to be reverted?

Now, I'm really confused. New tests wouldn't have passed prior to creating the original PR if there was such a missing dependency.

Everything with blockchain-core remain a bit alien to me since I don't follow the relevant Discord channels or its PRs closely enough. Therefore, I'll leave that decision to others. My rationale was that if this feature requires a chain var which has been put on hold, there's no reason for this feature code to exist (for now).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many lora_subnet:parse_netid:Undefined CRASH REPORT
2 participants