Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Bump outbound gossip connections to 6 for seed nodes #1507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jadeallenx
Copy link
Contributor

No description provided.

@madninja
Copy link
Member

@jadeallenx This PR is mostly outdated after the merge of #1541, except for the change in outbound connections of seed.config vs sys.config. Can this PR be freshened up?

@jadeallenx jadeallenx changed the title Bump outbound gossip connections to 4 Bump outbound gossip connections to 6 for seed nodes Apr 14, 2022
@ci-work
Copy link
Contributor

ci-work commented Apr 14, 2022

why so low for seed nodes? 4000 in and 6 out seems like a gossip vacuum rather than seeder
q2. how many other seed nodes does each seed node connect to in order to keep in sync with changes other seeds receive, and be able to provide the best lookup service? presume answer is length(maybe_lookup_seed_in_dns(SeedNodes)) - 1

@madninja
Copy link
Member

why so low for seed nodes? 4000 in and 6 out seems like a gossip vacuum rather than seeder
q2. how many other seed nodes does each seed node connect to in order to keep in sync with changes other seeds receive, and be able to provide the best lookup service? presume answer is length(maybe_lookup_seed_in_dns(SeedNodes)) - 1

Actually per https://github.com/helium/blockchain-core/blob/master/src/blockchain_sup.erl#L103-L104 the outbound_gossip_connections should be 18 if max_inbound is 6 right?

@ci-work
Copy link
Contributor

ci-work commented Apr 15, 2022

why so low for seed nodes? 4000 in and 6 out seems like a gossip vacuum rather than seeder
q2. how many other seed nodes does each seed node connect to in order to keep in sync with changes other seeds receive, and be able to provide the best lookup service? presume answer is length(maybe_lookup_seed_in_dns(SeedNodes)) - 1

Actually per https://github.com/helium/blockchain-core/blob/master/src/blockchain_sup.erl#L103-L104 the outbound_gossip_connections should be 18 if max_inbound is 6 right?

Inbound is 4000, so outbound 6000 by that working lol

@madninja
Copy link
Member

why so low for seed nodes? 4000 in and 6 out seems like a gossip vacuum rather than seeder
q2. how many other seed nodes does each seed node connect to in order to keep in sync with changes other seeds receive, and be able to provide the best lookup service? presume answer is length(maybe_lookup_seed_in_dns(SeedNodes)) - 1

Actually per https://github.com/helium/blockchain-core/blob/master/src/blockchain_sup.erl#L103-L104 the outbound_gossip_connections should be 18 if max_inbound is 6 right?

Inbound is 4000, so outbound 6000 by that working lol

why yes it would be..

@jadeallenx
Copy link
Contributor Author

We talked this over and the inbound number is so high because it needs to be high to handle the load for ARP requests which is the seed nodes primary function. The outbound number is really about outbound gossip and it's fine at this level. So we're going to leave it as-is in this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants