This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Introduce metrics framework based on telemetry events #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
requested review from
andymck,
evanmcc,
jadeallenx,
jontow,
madninja and
Vagabond
jadeallenx
reviewed
May 11, 2022
jeffgrunewald
force-pushed
the
jg/grpc_metrics
branch
from
d94be9d
to
08d7b73
Compare
jeffgrunewald
force-pushed
the
jg/grpc_metrics
branch
from
d647beb
to
432cfad
Compare
jeffgrunewald
force-pushed
the
jg/grpc_metrics
branch
4 times, most recently
from
ffae14c
to
8c8d36d
Compare
jeffgrunewald
force-pushed
the
jg/grpc_metrics
branch
from
8c8d36d
to
a307baf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumes the following upstream PRs to add telemetry events to the underlying blockchain-core and grpcbox libraries that will emit telemetry events related to block production and grpc connections/request latencies.
The metrics framework is designed to be extensible and consume any telemetry events being generated within the miner software or any upstream dependencies and by added to the expected prometheus scrape target endpoint by updating the handler function with a new function head (
src/metrics/miner_metrics_server.erl), and by updating the event specs in the metrics header file (include/metrics.hrl) and then adding the desired groups of metrics to your sysconfig profile.Depends on merges of:
novalabsxyz/grpcbox#3
helium/blockchain-core#1336
helium/sibyl#42
and then subsequent cleanup of the rebar.config/rebar.lock files.