Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Use the correct chain var for bloom filter reset #1594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mawdegroot
Copy link
Contributor

When running with validator challenges the bloom filter is still reset using poc_challenge_interval which is not used with validator challenges. Change to the correct chain variable and use GatewayCount / PocChallengeRate to mimic old bloom filter behavior.

blockchain_ledger_v1:gateway_count is quite slow so adding it to the record to cache the result for the duration of one interval length.

@abhay
Copy link
Contributor

abhay commented May 21, 2022

This likely needs some testing but it also needs a guard around rollback scenario if we (unlikely) roll back the light hotspot activation.

@mawdegroot
Copy link
Contributor Author

From what I understood the miner_poc_mgr is only used with validator challenges, if we roll back to hotspot challenges we will fall back to miner_poc_statem so a guard shouldn't be necessary.

How do I best test this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants