Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use link to sqlx repo instead of fork #893

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Use link to sqlx repo instead of fork #893

merged 2 commits into from
Nov 11, 2024

Conversation

kurotych
Copy link
Member

  • Use the official SQLx repository link instead of the fork. It makes future updates a little bit easier and more transparent and we don't have to host fork in our repo.
  • Remove the unused helium-crypto dependency from boost_manager.

Updating SQLx further is currently impossible due to package conflicts, mainly because we are using an outdated Solana library.
Upgrading solana-client, solana-sdk, and solana-program to version ^2 could theoretically resolve these conflicts.

@kurotych kurotych marked this pull request as ready for review November 11, 2024 12:09
Copy link
Contributor

@jeffgrunewald jeffgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, did we really fork this and not make any changes instead of just pinning the original repo? Wild

@kurotych
Copy link
Member Author

Wow, did we really fork this and not make any changes instead of just pinning the original repo? Wild

It looks like. I think it was for the time we were waiting the changes in launchbadge/sqlx@42dd78f to be accepted into main branch.

@kurotych kurotych merged commit a1c9f27 into main Nov 11, 2024
17 checks passed
@kurotych kurotych deleted the use-sqlx-repo branch November 11, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants