Modeled coverage #344
Merged
Modeled coverage #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madninja
reviewed
Jun 20, 2023
| message radio_hex_signal_level { | ||
| uint64 hex_id = 1; | ||
| signal_level signal_level = 2; | ||
| double signal_power = 3; |
There was a problem hiding this comment.
Can we use a u32 or something like we do with IoT PoC and use ddbm? trying to avoid floats since they're massive and terrible language support
kurotych
reviewed
Jun 21, 2023
kurotych
reviewed
Jun 22, 2023
| string location = 1; | ||
| signal_level signal_level = 2; | ||
| // Signal power of the radio in dBm (decibel-milliwatts) | ||
| double signal_power = 3; |
There was a problem hiding this comment.
i see a resolved comment but no explanation? don't we typically have this type of field as uint32 or uint64 with the ddBm scale comment?
bbalser
approved these changes
Jun 29, 2023
jeffgrunewald
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.