Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating comment for invalidated_radio_threshold_report_req_v1 timestamp #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riobah
Copy link
Contributor

@riobah riobah commented Mar 9, 2024

The comment states the timestamp field of invalidated_radio_threshold_report_req_v1 message is in milliseconds but the data shows that it is in seconds:

verified_invalidated_radio_threshold_ingest_report_v1 {
  status: 0,
  timestamp: 1709986943271n,
  report: invalidated_radio_threshold_ingest_report_v1 {
    receivedTimestamp: 1709986005909n,
    report: invalidated_radio_threshold_report_req_v1 {
      cbsdId: '',
      hotspotPubkey: <Buffer 04 01 03 01 00 b4 f5 e0 a9 e9 49 ae 51 42 bc f5 b6 5e 1b d7 fb ef 87 14 ad 85 00 40 b4 17 b6 24 9c 6e a4 76 28 fd 0b d0 49 41 54 2f 32 c2 c5 f4 93 90 ... 214 more bytes>,
      reason: 0,
      timestamp: 1709985995n,
      carrierPubKey: <Buffer 01 9e 2e 85 d5 8c c4 d7 d9 4c ae 87 45 ae c6 bd fc 9b e6 0f bd 2f da bf 37 e3 38 4d 6c 9f 58 09 1a>,
      signature: Uint8Array(0) []
    }
  }
}

…amp - it is seconds, not milliseconds

The comment states the `timestamp` field of `invalidated_radio_threshold_report_req_v1` message is in milliseconds but the data shows that it is in seconds: 

```
verified_invalidated_radio_threshold_ingest_report_v1 {
  status: 0,
  timestamp: 1709986943271n,
  report: invalidated_radio_threshold_ingest_report_v1 {
    receivedTimestamp: 1709986005909n,
    report: invalidated_radio_threshold_report_req_v1 {
      cbsdId: '',
      hotspotPubkey: <Buffer 04 01 03 01 00 b4 f5 e0 a9 e9 49 ae 51 42 bc f5 b6 5e 1b d7 fb ef 87 14 ad 85 00 40 b4 17 b6 24 9c 6e a4 76 28 fd 0b d0 49 41 54 2f 32 c2 c5 f4 93 90 ... 214 more bytes>,
      reason: 0,
      timestamp: 1709985995n,
      carrierPubKey: <Buffer 01 9e 2e 85 d5 8c c4 d7 d9 4c ae 87 45 ae c6 bd fc 9b e6 0f bd 2f da bf 37 e3 38 4d 6c 9f 58 09 1a>,
      signature: Uint8Array(0) []
    }
  }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants