Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

dynamic config #80

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

dynamic config #80

wants to merge 1 commit into from

Conversation

paul-thompson-helix
Copy link
Member

Continuing from #79

Next aim is to have the command to configure a deployment.

Proposed command signature for 'configure' a deployment

configure configName configMode deploy

to configure named configName into given configMode of the given deployment

configure configName configMode deploy

to configure named configName into given configMode of the given deployment
@paul-thompson-helix paul-thompson-helix changed the title dynamic config continued dynamic config Oct 9, 2019
@timbod7
Copy link
Contributor

timbod7 commented Oct 14, 2019

I wonder if the syntax might be clearer as:

camus2 deploy-set-mode DEPLOY_NAME CONFIG_NAME=CONFIG_MODE 

@paul-thompson-helix
Copy link
Member Author

I like the <cfgname>=<cfgmode> that you suggest.

I was aiming for consistency with c2 connect <endpoint> <deploy> with having the <deploy> on the end and consistency with other commands by having commands in the form:
c2 <verb> ... and avoiding dashed command line args.

So
c2 <something> <cfgname>=<cfgmode> <deploy>

I think configure reads quite well in this context:

I.E. the help would read:
Deployment with a proxy: c2 status [--show-slaves] c2 start <release> c2 stop <release> c2 connect <endpoint> <deploy> c2 disconnect <endpoint> c2 configure <cfgname>=<cfgmode> <deploy>

Something to think about - but yes I'll proceed with parsing the arg string <cfgname>=<cfgmode> when I get onto it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants