Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated weapon data and added the newest warbond. #60

Merged
merged 14 commits into from
Oct 6, 2024
Merged

Updated weapon data and added the newest warbond. #60

merged 14 commits into from
Oct 6, 2024

Conversation

Stonemercy
Copy link
Collaborator

ID's are probably completely wrong but idk how to get the actual ones 🤷🏻‍♂️
Fixes #59, and #57

Not sure where "polaris" came from but all sources I see are "polar"
Most of the new/changed item ID's are incorrect and will need to be changed (I don't know them).
dealloc
dealloc previously approved these changes Oct 2, 2024
@dealloc
Copy link
Member

dealloc commented Oct 2, 2024

just waiting for @chatterchats to approve, he's the boss of these JSON files :)

dealloc
dealloc previously approved these changes Oct 4, 2024
Copy link
Member

@dealloc dealloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for picking that one up as well

Copy link
Collaborator

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All IDs added, just need @dealloc to merge and squash

@dealloc dealloc merged commit 2522dfc into helldivers-2:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: MP-98 Knight is missing from primary.json
3 participants