WIP: Add JS(X)/TS(X) linting #45
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, CI is (rightly) failing due to the linting errors. But CI configuration is correct. |
hello-amal
force-pushed
the
amaln/pre_commit_linting
branch
from
2402ff5 to
3233375
Compare
hello-amal
force-pushed
the
amaln/pre_commit_js_linting
branch
from
bb27b33 to
58fc2c0
Compare
hello-amal
force-pushed
the
amaln/pre_commit_linting
branch
from
3233375 to
75af5e0
Compare
bm-hellorobot
force-pushed
the
amaln/pre_commit_js_linting
branch
from
58fc2c0 to
7f8611d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, in partial service of #43 , builds off of #44 to add JS(X)/TS(X) linting.
This PR is a work-in-progress; although the pre-commit hooks are properly configured to lint the repository (and that has been tested), they generate hundreds of warnings/errors. Most are straightforward to fix, but some fixes require legacy knowledge of the codebase (e.g., the fact that
relativePoseno longer exists as a type). Those lint errors are better suited for @hello-vinitha to address.Testing procedure
TODO
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge