Fix flaky test for pick_should_pick_key_pairs_corresponding_to_keys #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a flaky test snippets.SnippetsTests#pick_should_pick_key_pairs_corresponding_to_keys
setup
Java version: 1.8.0_382
Maven version: Apache Maven 3.6.3
Test failure Reproduction
The test snippets.SnippetsTests#pick_should_pick_key_pairs_corresponding_to_keys can fail as the underlying code uses a HashMap and containsExactly assumes the order of the elements in the HashMap This issue was verified using the NonDex plugin.
Steps:
Use the nondex .sh script from "Helper scripts in cmds" section
NonDex test failure:
Root cause and fix
containsExactly assumes the order of the elements in the HashMap, so using containsOnly can be order agnostic. But contains only broaden the concept about the exactly, so we check the size first then compare the content