[FEAT] Splash, SignIn, SignUp 로깅 세팅 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acious
reviewed
Nov 26, 2023
Comment on lines
+14
to
+19
| setLoggingScheme( | ||
| eventLogName = eventLogName, | ||
| screenName = screenName, | ||
| logVersion = logVersion, | ||
| logData = logData.toMutableMap() | ||
| ) |
acious
reviewed
Nov 26, 2023
Comment on lines
+123
to
+129
| private fun shotSignInExposureLogging() { | ||
| val scheme = SwmCommonLoggingScheme.Builder() | ||
| .setEventLogName("signInExposure") | ||
| .setScreenName(this.javaClass) | ||
| .build() | ||
| signInViewModel.shotSignInExposureLogging(scheme) | ||
| } |
There was a problem hiding this comment.
모든 액티비티마다 이러한 로깅을 쏘게된다면 BaseActivity에 묻어서 로깅을 처리할 방법은 없을지도 생각해보면 좋을거같아요.
|
미뤄두었던 요청하신 마지막 코드리뷰 진행했습니다 ㅎㅎ 내년에는 새로운 시간과 주제로 또 같이 많이 이야기해보시죠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To 멘토님
SwmCommonLoggingScheme는 backend api에 만들때와 같이 map 형태를 활용합니다ScreenName,EventName을 Builder를 활용해 지정하게끔 변경했습니다.