Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Notification Center / Timestamp 추가 #209

Merged
merged 7 commits into from
Feb 3, 2024

Conversation

KxxHyoRim
Copy link
Member

결과물 📱

image

전달사항

1. LGTMTimestamp class 추가

  • 유리아! LGTMTimestamp class 추가했어. 여러 화면에서 많이 쓰일것같아서 ㅎㅎ
  • setTimeStamp()함수로 시간 지정해줄수 있어!

2. TimeFormatter 변경

  • 기존에 유리가 추가해준대로 pattern만 "a h:mm"로 지정한 경우에는 Default Locale에 따라서 String이 나오더라구
  • 내 에뮬에서 기본 언어가 Eng로 지정되어 있으면 '오전/오후' 대신 'AM/PM'으로 표기돼서 우선 Ko-kr locale 명시적으로 지정해줬어!
  • 네이밍도 좀 구체적으로 수정했다! korean12HourTimeFormatter

@KxxHyoRim KxxHyoRim requested a review from 915dbfl February 2, 2024 08:55
@KxxHyoRim KxxHyoRim self-assigned this Feb 2, 2024
Copy link
Collaborator

@915dbfl 915dbfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✨✨✨

@KxxHyoRim KxxHyoRim merged commit 3aaf0d3 into develop Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants