Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] 미션 제안 화면 UI 작업 (#204) #215

Merged
merged 36 commits into from
Feb 28, 2024
Merged

[UI] 미션 제안 화면 UI 작업 (#204) #215

merged 36 commits into from
Feb 28, 2024

Conversation

915dbfl
Copy link
Collaborator

@915dbfl 915dbfl commented Feb 13, 2024 •
edited
Loading

전달사항

1. LGTMEditText에서 maxLength 없는 NoLimitEditText를 별도로 구성!
  • LGTMEditText 활용해서 코드상에서 maxLength를 변경하려고 했는데 적용이 안돼서 따로 파일을 빼게 되었어!!
  • NoLimitEiditText는 compose로 작성하려다가 custom이 잘 안돼서 나중에 따라 issue 파서 진행하려고!
2. createSuggestionActivity BaseComposeActivity -> BaseActivity로 상속 수정!
  • LGTMComfirmationDialog를 활용하려면 AppCompatActivity를 상속해야 해서 일단은 BaseActivity를 상속하게 바꾸게 되었어!!
  • 이건 나중에 dialog가 Compose로 변경되면 BaseComposeActivity로 수정하면 될 것 같아!

코드 리뷰 후 진행작업

  1. LGTMNoLimitEditText 대신 LGTMEditText 활용 방안으로 수정
  2. CreateSuggestionRequest DTO -> VO 워딩 수정
  3. 미션 제안 화면 keyboard에 따른 focus 처리
  4. bottomSheet compose component로 구성!

915dbfl added 21 commits February 5, 2024 23:11
@915dbfl
[FEAT] createSuggestion activity / viewModel / composable screen 구성(로…
65c8dd3 
…직x) (#204)
@915dbfl
[FEAT] CreateSuggestionActivity navigation 설정 및 적용 (#204)
10b43ae
@915dbfl
[FEAT] NoLimitEditText custom view 추가 (#204)
8b2c93c
@915dbfl
[FEAT] CreateSuggestionScreen 화면 구성(api 연동x) (#204)
dd2c212
@915dbfl
[FEAT] createSuggestion request / response data class 생성 (#204)
c0757fb
@915dbfl
[FEAT] createSuggestion api retrofit 적용 (#204)
7370467
@915dbfl
[CHORE] lifecycle-viewmodel-compose 의존성 추가 (#204)
4f5c300
@915dbfl
[FEAT] title / content required infoType 추가 (#204)
94d9706
@915dbfl
[CHORE] compose runtime livedata 의존성 추가 (#204)
f5947c4
@915dbfl
[FEAT] modifier throttleClickable 확장 함수 정의 (#204)
94d346a
@915dbfl
[FEAT] LGTMEditText에 stateBinding 및 onTextChangedListener 로직 추가 (#204)
f0584df
@915dbfl
[FEAT] BackButton에 onClick 파라미터 추가 (#204)
080cc8e
@915dbfl
[FEAT] createSuggestionViewModel 구성 및 createSuggestionScreen과 연동 (#204)
1385573
@915dbfl
[CHORE] hilt-compose, lifecycle-runtime-compose 의존성 추가 (#204)
3739a0c
@915dbfl
[FEAT] createSuggestionRequestDTO 파라미터 not nullable로 변경 및 createSugge…
344134c 
…stionViewModel에 createSuggestion 로직 작성 (#204)
@915dbfl
[FIX] composeSingleCLickListener 정의 및 throttleClickable 로직 수정 (#204)
79a1863
@915dbfl
[FEAT] createSuggestion api 연동 마무리 (#204)
7c6b34d
@915dbfl
[REFACTOR] collectAsState 대신 collectAsStateWithLifecycle 사용 (#204)
a6a5c4a
@915dbfl
[FEAT] createSuggestionActivity finish 로직 파라미터로 주입 (#204)
d8b8ad0
@915dbfl
[FEAT] dialogFragment 활용을 위해 createSuggestionActivity appCompatActivi…
27429f6 
…ty 상속 (#204)
@915dbfl
[FEAT] 미션 제안 중단 dialog 처리 (#204)
8713bbb
@915dbfl 915dbfl requested a review from KxxHyoRim February 13, 2024 11:04
@915dbfl 915dbfl self-assigned this Feb 13, 2024
@915dbfl 915dbfl merged commit 165c88f into develop Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KxxHyoRim KxxHyoRim Awaiting requested review from KxxHyoRim

Assignees

@915dbfl 915dbfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] 미션 제안 화면 UI 작업
1 participant
@915dbfl