More bazelmod preparations #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In `b/.pre-commit-config.yaml`
* Prevented reformatting of .patch files
* In `MODULE.bazel`
* Changed to get hedron-compile-commands and llvm through includes so they can be patched out in modules.
* clang-format
* Changed `//mbo//mope/clang_format/build_setting_default` to `""` so we automatically get to choose between repo provided and full automatic finding.
* Changed `mbo/mope/mope.bzl` to:
* If (newly) `_CLANG_FORMAT_BINARY` var is set, then disable sandboxing so all possible targets can actually be found.
* Added additional location to find clang-format including both bazel 7.* and bazel 8.* locations.
* Added ability to copy input to output file as a last fallback.
* Added a log statement to denot the used clang-format binary and version in case an automatically found one was used.
Fab-Cat
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More bazelmod preparations
b/.pre-commit-config.yamlMODULE.bazel//mbo//mope/clang_format/build_setting_defaultto""so we automatically get to choose between repo provided and full automatic finding.mbo/mope/mope.bzlto:_CLANG_FORMAT_BINARYvar is set, then disable sandboxing so all possible targets can actually be found.