Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from v3 to v4 in example action in README.md #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zckv
Copy link

@zckv zckv commented Aug 1, 2024

Hello 👋

Simple change in the readme.md, to reflect the deprecation of actions/checkout@v3
The change was made in the test_action in a917fd1, so I assume it works well.

@zckv zckv force-pushed the bump_readme_checkout branch from 671f95f to 9dc5362 Compare August 1, 2024 14:34
Copy link

@dnskr dnskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zckv Could you please fix a typo from exemple to example in the PR title and commit message?

@zckv zckv changed the title Bump actions/checkout from v3 to v4 in exemple action in README.md Bump actions/checkout from v3 to v4 in example action in README.md Dec 16, 2024
@zckv zckv force-pushed the bump_readme_checkout branch from 9dc5362 to 3e49740 Compare December 19, 2024 08:26
@zckv
Copy link
Author

zckv commented Dec 19, 2024

Done, thanks for pointing it out :)

@dnskr
Copy link

dnskr commented Dec 19, 2024

I think you also need to sign you commit to pass DCO: https://github.com/helm/chart-releaser-action/pull/206/checks?check_run_id=34641574402

@zckv zckv force-pushed the bump_readme_checkout branch from 3e49740 to 708ad6c Compare December 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants