Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a "match_tags" option #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dunglas
Copy link

@dunglas dunglas commented Jul 12, 2021

I use this action to release the chart of Mercure.
We use a monolithic Git repository containing several projects, including the Helm chart.
Currently, this action isn't compatible with our setup because it computes the changes
made to the chart since the previous tag.

In our case, we also use tags for other projects in the same repository,
so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository).

This PR introduces a match_tags option allowing to filter the tags to match using a glob.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm those changes

@cpanato cpanato requested a review from unguiculus July 26, 2021 12:00
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

@dunglas
Copy link
Author

dunglas commented Apr 25, 2023

@cpanato rebased, please double-check

@dunglas dunglas force-pushed the feat/match-tags branch 2 times, most recently from 54b665c to 5f14712 Compare May 17, 2023 13:55
@dunglas
Copy link
Author

dunglas commented May 17, 2023

Fixed a rebasing issue. I manually tested the action and it works.

I use this action to release the chart of [Mercure](https://mercure.rocks).
We use a monolithic Git repository containing several projects, including the Helm chart.
Currently, this action isn't compatible with our setup because it computes the changes
made to the chart since the previous tag.

In our case we also use tags for other projects in the same repository,
so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository).

This PR introduces a `match_tags` option allowing to filter the tags to match using a glob.

Signed-off-by: Kévin Dunglas <[email protected]>
Signed-off-by: Kévin Dunglas <[email protected]>
@dunglas dunglas requested a review from cpanato July 18, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants