-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a "match_tags" option #89
Open
dunglas
wants to merge
1
commit into
helm:main
Choose a base branch
from
dunglas:feat/match-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoireHebert
approved these changes
Jul 12, 2021
cpanato
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm those changes
cpanato
requested changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need rebase
dunglas
force-pushed
the
feat/match-tags
branch
from
April 25, 2023 10:24
3ba627b
to
bdec858
Compare
@cpanato rebased, please double-check |
dunglas
force-pushed
the
feat/match-tags
branch
2 times, most recently
from
May 17, 2023 13:55
54b665c
to
5f14712
Compare
Fixed a rebasing issue. I manually tested the action and it works. |
I use this action to release the chart of [Mercure](https://mercure.rocks). We use a monolithic Git repository containing several projects, including the Helm chart. Currently, this action isn't compatible with our setup because it computes the changes made to the chart since the previous tag. In our case we also use tags for other projects in the same repository, so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository). This PR introduces a `match_tags` option allowing to filter the tags to match using a glob. Signed-off-by: Kévin Dunglas <[email protected]> Signed-off-by: Kévin Dunglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this action to release the chart of Mercure.
We use a monolithic Git repository containing several projects, including the Helm chart.
Currently, this action isn't compatible with our setup because it computes the changes
made to the chart since the previous tag.
In our case, we also use tags for other projects in the same repository,
so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository).
This PR introduces a
match_tags
option allowing to filter the tags to match using a glob.