feat: options to configure chart upgrade strategy #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cpanato, would you have time to look at this? Sorry, I can't add/tell who to request reviews :D |
|
This is great, this would fix the issues I'm having where the chart upgrade path cannot be tested because of the adding of new default values which don't get included in the upgrade. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Signed-off-by: Thuan Vo <[email protected]>
|
Hi, would anyone mind having a look at this PR? I think it would be useful for testing with different upgrade paths. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added options (i.e.
--upgrade-strategy <option>) to configure upgrade strategy for chart values. This allows maintainers to choose whichever upgrade paths align with their charts.Without specifying the flag, default to
reuse-valuesfor backwards compatibility.Follow up for #531
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #525Special notes for your reviewer:
Sorry if it duplicates any in-progress work. Please let me know what you think :D