feat: allow user set forcePathStyle for s3 storage #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warjiang
force-pushed
the
feat/amazon-force-path-style
branch
2 times, most recently
from
ca7f6ec
to
7a98ed3
Compare
Signed-off-by: warjiang <[email protected]>
warjiang
force-pushed
the
feat/amazon-force-path-style
branch
from
7a98ed3
to
9cc2c62
Compare
|
somthing wrong with git(dco not works with ssh ), still make dco finally |
|
@warjiang Hi , we just release the storage v0.14.1 , can you fix your |
warjiang
force-pushed
the
feat/amazon-force-path-style
branch
3 times, most recently
from
db317d6
to
f25b9d2
Compare
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
warjiang
force-pushed
the
feat/amazon-force-path-style
branch
from
f25b9d2
to
5d5bdf5
Compare
warjiang
changed the title
scbizu
approved these changes
Oct 28, 2023
|
@cbuto PTAL |
|
can anyone help to merge this pr, i want to use official chartmuseum instead of self build, thks |
|
@warjiang try our canary image . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Note: This PR depends on the merger of another PR to be merged. We have mentioned a PR in chartmuseum/storage to support users to manually set
s3ForcePathStyle. After the pr of storage is merged, I will remove the WIP status of the current PR.This PR mainly provides support for command line parameters, allowing users to set s3ForcePathStyle through command line parameters.
If possible, anyone can help me review the PR in chartmuseum/storage.
thks