Don't return error when repos have no chart

Fix #632 I build a chartmuseum service which has no charts, then add the chartmuseum repo into kubeapps. But I get a 'error' pod, that is unfriendly. I think it is better to add log for it. Signed-off-by: FengyunPan2 <[email protected]>
helm · May 27, 2019 · 86b6e66 · 86b6e66
1 parent f8afab9
commit 86b6e66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cmd/chart-repo/utils.go b/cmd/chart-repo/utils.go
@@ -99,7 +99,8 @@ func syncRepo(dbSession datastore.Session, repoName, repoURL string, authorizati
 
 	charts := chartsFromIndex(index, r)
 	if len(charts) == 0 {
-		return errors.New("no charts in repository index")
+		log.Warnf("The repository %s has no charts.", repoName)
+		return nil
 	}
 	err = importCharts(dbSession, charts)
 	if err != nil {

diff --git a/cmd/chart-repo/utils_test.go b/cmd/chart-repo/utils_test.go
@@ -587,5 +587,5 @@ func Test_emptyChartRepo(t *testing.T) {
 	m := mock.Mock{}
 	dbSession := mockstore.NewMockSession(&m)
 	err := syncRepo(dbSession, "testRepo", "https://my.examplerepo.com", "")
-	assert.ExistsErr(t, err, "Failed Request")
+	assert.NoErr(t, err)
 }