Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support discovery of suites with failed initialization by UniqueId #110

Closed
wants to merge 2 commits into from
Closed

Support discovery of suites with failed initialization by UniqueId #110

wants to merge 2 commits into from

Conversation

pshevche
Copy link

See the linked issue for more context.

Resolves #109

@pshevche pshevche mentioned this pull request May 19, 2023
Open
@giurim
Copy link
Contributor

giurim commented May 19, 2023

Nice!

Will look into it more detailed, will check if we need this mechanism at all.
There are some whitespace only modifications. Are those because of different tab-configs or those were not properly formatted? If the former can you please remove them, because next time I commit they will be formatted back. Maybe I should add some editor config files.

@pshevche pshevche force-pushed the pshevche/respect-id-selectors-for-init-errors branch from a2c9dcf to d133fdf Compare May 19, 2023 13:51
@pshevche
Copy link
Author

Nice!

Will look into it more detailed, will check if we need this mechanism at all. There are some whitespace only modifications. Are those because of different tab-configs or those were not properly formatted? If the former can you please remove them, because next time I commit they will be formatted back. Maybe I should add some editor config files.

Thank you! I removed whitespace changes, looks better now

@pshevche pshevche closed this by deleting the head repository Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support discovery of suites with failed initialization by UniqueId
2 participants
@pshevche @giurim