Drop Helm v2 support #613
Merged
Drop Helm v2 support #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomudk
force-pushed
the
patch-2
branch
2 times, most recently
from
efeb947 to
e0b8d7a
Compare
|
@mumoshu do you think is ok that drop helm v2 support in the next version? |
|
@yxxhero I believe so. I presume Helm v2 has been deprecated since Sep 2020 and not maintained since Dec 2020. It's 2023, and no one should be using Helm v2! |
|
@xiaomudk yeah. looking forward to updating. 💯 |
xiaomudk
force-pushed
the
patch-2
branch
7 times, most recently
from
18eb77b to
5c9d412
Compare
yxxhero
reviewed
Jan 10, 2023
| {Name: "test2", Flags: []string(nil)}, | ||
| {Name: "test3", Flags: []string(nil)}, | ||
| {Name: "test2", Flags: []string{}}, | ||
| {Name: "test3", Flags: []string{}}, |
yxxhero
reviewed
Jan 10, 2023
| @@ -510,14 +508,11 @@ releases: | |||
| {label: "name!=", expectedCount: 0, expectErr: true, errMsg: "in ./helmfile.yaml: in .helmfiles[0]: in /path/to/helmfile.d/a1.yaml: malformed label: name!=. Expected label in form k=v or k!=v"}, | |||
| {label: "name", expectedCount: 0, expectErr: true, errMsg: "in ./helmfile.yaml: in .helmfiles[0]: in /path/to/helmfile.d/a1.yaml: malformed label: name. Expected label in form k=v or k!=v"}, | |||
| // See https://github.com/roboll/helmfile/issues/193 | |||
| {label: "duplicatedNs=yes", expectedCount: 0, expectErr: true, errMsg: "in ./helmfile.yaml: in .helmfiles[2]: in /path/to/helmfile.d/b.yaml: duplicate release \"foo\" found in namespace \"zoo\" in kubecontext \"default\": there were 2 releases named \"foo\" matching specified selector"}, | |||
| {label: "duplicatedCtx=yes", expectedCount: 0, expectErr: true, errMsg: "in ./helmfile.yaml: in .helmfiles[2]: in /path/to/helmfile.d/b.yaml: duplicate release \"foo\" found in namespace \"zoo\" in kubecontext \"default\": there were 2 releases named \"foo\" matching specified selector"}, | |||
| {label: "duplicatedNs=yes", expectedCount: 0, expectErr: true, errMsg: "in ./helmfile.yaml: in .helmfiles[2]: in /path/to/helmfile.d/b.yaml: duplicate release \"foo\" found in kubecontext \"default\": there were 2 releases named \"foo\" matching specified selector"}, | |||
yxxhero
reviewed
Jan 10, 2023
| helmV3ListFlags = "--kube-contextdefault--uninstalling--deployed--failed--pending" | ||
| helmV3ListFlagsWithoutKubeContext = "--uninstalling--deployed--failed--pending" | ||
| ) | ||
|
|
||
| func listFlags(namespace, kubeContext string) string { |
There was a problem hiding this comment.
add some tests for this function will be better.
|
@xiaomudk Thanks for your great work. |
yxxhero
reviewed
Jan 10, 2023
| @@ -26,6 +26,10 @@ func NewRun(st *state.HelmState, helm helmexec.Interface, ctx Context) *Run { | |||
| panic("Assertion failed: helmexec.Interface must not be nil") | |||
| } | |||
|
|
|||
| if !helm.IsHelm3() { | |||
| panic("helmfile has deprecated helm2 since v1.0") | |||
There was a problem hiding this comment.
Good idea, panic message is not very friendly
| @@ -289,7 +288,7 @@ exec: helm --kube-context dev upgrade --install release chart --timeout 10 --wai | |||
| buffer.Reset() | |||
| err = helm.SyncRelease(HelmContext{}, "release", "chart") | |||
| expected = `Upgrading release=release, chart=chart | |||
| exec: helm --kube-context dev upgrade --install release chart | |||
| exec: helm --kube-context dev upgrade --install release chart --history-max 0 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Probably because 0 is the empty value hence the default value for the HistoryMax field of ReleaseSpec? It's propagated via the --history-max flag here:
Line 255 in 1f134d9
No behavior change introduced in this pull request. I presume it's just that we turned this helm v2 based test to helm v3 based one and the additional
--history-max flag is the consequence of that.
Signed-off-by: xiaomudk <[email protected]>
Signed-off-by: xiaomudk <[email protected]>
Signed-off-by: xiaomudk <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#589
Signed-off-by: xiaomudk [email protected]