fix empty yaml on documents with comment only sections #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alstephenclaypool
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
|
@alstephenclaypool please fix DCO issue. |
…sections Signed-off-by: Stephen Claypool <[email protected]>
alstephenclaypool
force-pushed
the
issue-165
branch
from
b3a4ca6 to
dc2a15c
Compare
|
@alstephenclaypool thanks for your PR. could you add some tests for this case? |
Signed-off-by: Stephen Claypool <[email protected]>
Sure, I've just pushed those to the PR, let me know if there are any other cases you'd like me to add. |
|
@alstephenclaypool thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at a fix on the issue I raised in #165
I'm not sure if this is too heavy of an approach or not, but found that it worked for what I was running into and figured I would propose it.