support AWS_ENDPOINT_URL configuration #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelano
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
the AWS SDK and CLI (currently only in Python) allows for configuration of the AWS endpoint URL via the `AWS_ENDPOINT_URL` environment variable [1]. the Golang AWS SDK does not currently support this, but according to GitHub issues, parity is on the way [2]. this change allows for a temporary workaround (it took two years for this support to make it to the Python SDK [3]) that allows `vals` to pick up the `AWS_ENDPOINT_URL` environment variable and configure the session accordingly. this allows for testing with non-AWS infrastructure like Localstack and Moto, and could even open the door for more comprehensive integration tests of the AWS functionality in this project without the need for using real AWS infrastructure. [1]: https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html [2]: aws/aws-sdk-go#4942 [3]: boto/boto3#2746 Signed-off-by: Stephen Delano <[email protected]>
sdelano
force-pushed
the
sdelano/support-aws-endpoint-url
branch
from
8d3d6cb to
ba42146
Compare
|
For the maintainers: I'd love to have a test for this, but it's been a while since I've written any meaningful amount of Go code and I couldn't find a great spot to slot a test into the existing tests. I also couldn't get the tests to run successfully and they were making outbound AWS calls using my AWS credentials. Any pointers to adding a relevant test here would be great. Thanks! |
|
@sdelano sorry for the delayed review. please fix the lint error. |
|
Right on, thanks everyone! Sorry I didn't come back to this sooner! I looked at the failure and thought "I have no idea how I made that fail" and then promptly filed it away as something to get back to later. |
|
@mumoshu great to see you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AWS SDK and CLI (currently only in Python) allows for configuration of the AWS endpoint URL via the
AWS_ENDPOINT_URLenvironment variable 1.the Golang AWS SDK does not currently support this, but according to GitHub issues, parity is on the way 2.
this change allows for a temporary workaround (it took two years for this support to make it to the Python SDK 3) that allows
valsto pick up theAWS_ENDPOINT_URLenvironment variable and configure the session accordingly.this allows for testing with non-AWS infrastructure like Localstack and Moto, and could even open the door for more comprehensive integration tests of the AWS functionality in this project without the need for using real AWS infrastructure.