feat(providers) initial implementation of pulumi provider #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agershman
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
agershman
force-pushed
the
pulumi-provider
branch
4 times, most recently
from
1c343aa to
4dec338
Compare
yxxhero
reviewed
Nov 4, 2023
agershman
force-pushed
the
pulumi-provider
branch
from
4dec338 to
989c698
Compare
agershman
force-pushed
the
pulumi-provider
branch
12 times, most recently
from
d7438ae to
56a8a19
Compare
|
@agershman please fix ci issues. |
agershman
force-pushed
the
pulumi-provider
branch
from
56a8a19 to
ab55949
Compare
@yxxhero should be good to go now. Thanks |
yxxhero
reviewed
Nov 24, 2023
| } | ||
|
|
||
| func (p *provider) GetString(key string) (string, error) { | ||
| tokens := strings.Split(key, "/") |
There was a problem hiding this comment.
@agershman we should check the length of tokens here. WDYT?
There was a problem hiding this comment.
Yep, I think that'd be helpful to be more explicit if the provided key is not in a supported format. Will address.
yxxhero
reviewed
Nov 24, 2023
pkg/providers/pulumi/pulumi.go
Outdated
| case "pulumistateapi": | ||
| state, err = p.getStateFromPulumiAPI() | ||
| default: | ||
| return "", fmt.Errorf("unsupported backend: %s", p.backend) |
There was a problem hiding this comment.
err = fmt.Errorf("unsupported backend: %s", p.backend)
agershman
force-pushed
the
pulumi-provider
branch
from
ab55949 to
9f93a65
Compare
Signed-off-by: Andrew Gershman <[email protected]>
agershman
force-pushed
the
pulumi-provider
branch
from
9f93a65 to
e9f10eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of a Pulumi provider backed by state. This first cut meets my use case of obtaining state from the Pulumi REST API. I've updated the readme with the relevant usage and a couple examples.