-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): Add support for fetching from k8s secrets #186
Conversation
Allows fetching values from Kubernetes secrets. Authentication to the Kubernetes cluster is managed by referencing the local kubeconfig. Signed-off-by: Bernardo Salazar <[email protected]>
a7a0cac
to
5d7d54e
Compare
Signed-off-by: Bernardo Salazar <[email protected]>
bbbcf33
to
ea63792
Compare
@bersalazar could you add some tests for this feature? |
What about config maps? Maybe we can prep to support them in the future by leaving room in the api for them? Maybe /[namespace/][apiVersion/kind/]name[#path.to.key] |
Definitely worth considering. Maybe in a future PR, happy to raise an issue for it once this one's merged. |
I still think we should ensure this implementation is future proof to reduce chances of breaking changes when we implement this. |
Signed-off-by: Bernardo Salazar <[email protected]>
@yxxhero added it |
@bersalazar please see my newest comments. it will be perfect after you update. |
Updates the reference to allow other Kubernetes objects like ConfigMaps, which can become a valid use case. Also adds unit tests. Signed-off-by: Bernardo Salazar <[email protected]>
@aslafy-z sure thing, I have modified the proposed API so its more generic and can cover ConfigMaps as well, eventually. Thanks for suggesting! it makes sense to avoid future breaking changes, as you mentioned. |
@yxxhero I've had a look at them and pushed updates, including unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking my point into account! Here's two little nit so we make the doc obvious for the secretref case
@bersalazar please fix lint error. |
Signed-off-by: Bernardo Salazar <[email protected]>
@yxxhero all good now, thanks. Do you mind having a look at helmfile/helmfile#1212? |
Signed-off-by: Bernardo Salazar <[email protected]>
Signed-off-by: Bernardo Salazar <[email protected]>
Allows fetching values from Kubernetes secrets.
Authentication to the Kubernetes cluster is managed by referencing the local kubeconfig.
Covers #185