fix(providers): k8s, log message getting into stdout #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfcnunes
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
lucasfcnunes
force-pushed
the
add-k8s-secrets-support
branch
from
ff85f68 to
282c842
Compare
|
Fix lint issue. |
lucasfcnunes
force-pushed
the
add-k8s-secrets-support
branch
3 times, most recently
from
e54d73f to
f24ac72
Compare
|
still has lint issue. |
|
@lucasfcnunes ping |
|
@lucasfcnunes thanks so much. |
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
mvdan/unparam#40 Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
lucasfcnunes
force-pushed
the
add-k8s-secrets-support
branch
from
f24ac72 to
7a7730e
Compare
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
lucasfcnunes
force-pushed
the
add-k8s-secrets-support
branch
from
7a7730e to
ab6c0a0
Compare
yxxhero
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Issue
A simple
vals get ref+k8s://... > result.txtresults in logs (stderr) mixing with result (stdout).Changes
fmt.Printf(->p.log.Debugf) PRINCIPALKubernetes secrets->Kubernetes(because of ConfigMap)return p, nilreturn k8s.New(l, provider), nilpatternsreturn result, errin some (unparam lint forbids all) custom functionsmake lint